-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to choose which "variable combinations" to use in a study? #101
Comments
This is perhaps just a guess, but perhaps the user may not have sufficient knowledge to decide what emissions (RCP) scenario to use. Maybe it could be simpler just to use a default scenario of RCP45 together with the baseline as a reference - meaning one less thing for the user to decide. Then, once the output from this scenario is presented, an option may be presented where the user can select one of the other emissions scenarios as a comparison? The time period could also be selected by the user from the start, with an option, that once the data is shown, another time period could be selected for comparison. |
@patrickkaleta , @therter : if we decide to go this way, such named combinations would need to be stored somewhere. Possibilities:
What would be the easiest to use by the "applications", e.g. by CISMET map application? FYI: I'm inclined to say "a paragraph in the group" because we could have the resources that use various variables in any step and because there is IMO no need to reuse this across studies. For the same reason, I'm inclined to say "let the user define this right at the start", but I'm not sure if that's really appropriate from the workflow point of view @ALL: WDYT? |
Yes, I was also thinking about letting the user choose parameters at the start and then be able to change them in the risk/impact section if they want. By the way, I already thought of providing additional information on RPCs - this is already in the system. We just need to make use of it. |
@p-a-s-c-a-l : I don't think that it's a good idea to postpone this issue because this would mean that @therter has to implement a map application first in such a way that all the combinations are shown (that's 27 or 48 layers for each resource in the DP that uses these variables, ups!) and later change this. It's IMO less work if we resolve this issue first. Once that's done, we will be able to count on the number of layers that needs to be shown in a map being "reasonable"; 10-20 rather than 100+ |
No, we don't show all possible layer combinations. I'm implementing the map component and the new table component. As starting point, choices are preselected (hardcoded) as suggested by Robert, Therefore no need for making a selection ATM. |
Ah, I understand. So we will pre-set some combinations and then the user choice can be added at a later time. Yes, makes sense and this will not cause work duplication as I feared. Good, let's put this "on hold" for now. Before I go away, here is a second design variant I thought of, for the reference: Reasoning:
|
As a tag for the resources, the "rcp45" scenario is classified as "effective-measures" with respect to greenhouse gas emissions. For completeness, rcp26 = early-response, and rcp85 = business-as-usual. |
I would also store it directly in the group and not the RIA GL-step (What if RIA step not available in selected Study type? What if this information is needed in a step prior to the RIA step? ...). Our components (map application, etc.) will most likely access this information via JSON:API, so I'm not sure if it would be easier to have it in a paragraph or a new node type - JSON:API and Group content have their issues and JSON:API with Paragraphs have not yet been tested by us (AFAIK). So, when we go back working on this, I would first test accessing paragraphs in a group via JSON:API and then make a decision on how to store this information. |
I have added a new "workaround implemented" flag to indicate that this isn't just on hold because we can't fix it, but that we simply don't need to fix it at the moment. |
Not sure which "workaround " you mean, AFAIK this isn't working yet. The additional EMIKAT In order to initialise the respective Map/Table iFrames with the proper query parameters, we have to provide a possibility to chose the parameters in CSIS and then include the choices in the CSIS_Helpers Module's JavaScript Object. So in principle I don't care where this information is actually stored (paragraph, etc.) als long as it is made available in JavaScript and not Drupal JSON:API. |
Decision: add a paragraph that allows user to set the three variables and give it a name Later extensions:
This should be ideally positioned right after choosing the study data package, so that we can provide immediate feedback if the chosen combination makes sense or not (also future extension). |
@RobAndGo : what is the meaning of Rare/Occasional/Frequent? |
I have added a The title is automatically built from the variable name, value and label/meaning on save. Thus, we can have this now: First one to be used with EMIKAT, the second with heat hazard data. |
@DenoBeno
|
Oh jee... This with the
In short, we need a help-taxonomy called "dp variable meanings". |
Implementation status:
@patrickkaleta : your turn to make use of this now... |
I've updated the
For the values I'm using whatever is stored for each of these DP variable meanings terms inside the meaning ID field. @p-a-s-c-a-l can you work with that or do you need additional adjustments?
|
Thanks, I've implemented it and it seems it work. At least the parameters are used in the table and map app, but there are still several problems with EMIKAT. I think we can now merge csis-helpers-module/feature/010-extend-entityinfo into dev. |
Ok I will do that. But first I will add the |
Done. |
This is basically done now. I'll open a new issue for allowing more than one preset and close this thread now. |
I couldn't figure out how this "variable meaning" stuff is supposed to work. As far as I understood, it could (?) provide a solution to the following problem: For the variable "Historical Time" (
Same problem for Now, in one Map there are both Hazard and EMIKAT layers. Which means URIs with This is rater unfortunate, since it is a "self-made problem" that adds a lot of unnecessary complexity to the codebase. So instead of trying to implement around a problem that we accidentally invented by ourselves, I propose to harmonise the variable values and get rid of the problem in the first place. Which means EMIKAT should accept |
@p-a-s-c-a-l, sorry but I had to take care of a lot of other stuff this week. What do you need from me? Should I start to upload the precipitation datasets into the data package? |
No, ATM it's not working yet and I had to take care about the periodic report. |
Related to: clarity-h2020/data-package#42, clarity-h2020/data-package#47, clarity-h2020/data-package#46, clarity-h2020/data-package#45
Possibly also related to https://github.com/clarity-h2020/emikat/issues/18
As discussed earlier today, we are overwhelming the users by letting them see all the possible combinations of the time_period (baseline+3), emission_scenario (baselive+3) and event frequency (3) = 27 or 48 combinations, depending how we count. From the users point of view both 27 and 48 qualify as "too many to deal with".
Consequently, we need a way to limit the number of combinations shown in some way. The question is "how"?
The text was updated successfully, but these errors were encountered: