Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data view needs to be improved #106

Closed
DenoBeno opened this issue Sep 27, 2019 · 5 comments
Closed

Data view needs to be improved #106

DenoBeno opened this issue Sep 27, 2019 · 5 comments
Assignees
Labels
BB: Data Dashboard Data Dashboard Building Block bug enhancement New feature or request on-hold Issue is on-hold and will be adressed later or closed question Further information is requested

Comments

@DenoBeno
Copy link

Two issues:

  1. duplication of content.
  2. we should (?) also include the "pseudo-resources" - adaptation options and vulnerabilities

Duplication of content
image

"Local effect apparent temperature" is listed 3x because it's featuring three tags that are relevant for this step: "heat wave", "consecutive summer days" and "heat wave duration". This view then produces three lines for the resource based on these three tags (I have added a content in parentheses to show what is going on. Originally it was just 3x the same title.):

Questions:

  1. Should the resource reference only one of them or not?
  • Pro: if only one of these tags remains, the data view will not show duplicates.
  • Contra: I don't know which one to keep. Probably other users will have the same problem.
  1. do we even need such a complex view? After all, we aren't presenting the data hierarchically anyway. If we don't care about the hierarchy, it would be easier to avoid the duplication.

Pseudo resources

Adaptation options and vulnerabilities could IMO be shown as a flat list rather than as a hierarchy. That could be done e.g. by attaching a simple(r) view with AOs & vulnerabilities to the existing data view.

One more question: why isn't this attached to the page in the same way as tables are? If it were, we could easily have per-step data views...

@DenoBeno DenoBeno added bug enhancement New feature or request question Further information is requested labels Sep 27, 2019
@DenoBeno
Copy link
Author

Update: in the "hazard characterization" step, the hierarchy is still shown, see illustration.
From https://csis.myclimateservice.eu/study/1/step/2/view/data

image

And the number of duplicates here is astonishing...
In exposure evaluation step too.

image

I have no clue why this isn't the case in "local effects" data tab. Also the input data for the local effects is not shown anymore. E.g. roads, railways, built up area etc.

@DenoBeno
Copy link
Author

DenoBeno commented Oct 1, 2019

@fgeyer16 : we will need to fix this one of these days. Maybe not you, but we need to at least clarify what is the best way to handle this before assigning it to anyone. Any suggestions?

@patrickkaleta
Copy link

The original idea of some sort of hierarchy goes back to the days when we used the Mock-up as a reference. But that would only work if resources would be assigned exactly one relevant tag. If they can have multiple ones, I don't know how we could build a hierarchy with a simple enough logic, so that it can be done inside a View.

So, before we show the same resource 2-3 times, or try to come up with a complicated logic that could build a hierarchy, I would rather drop this and instead show a simple list or table with the included tags right next to each resource and add a filter function on top of the page.

@fgeyer16 : we will need to fix this one of these days...

Agreed. It is not that urgent at the moment, so I'm putting this on hold.

@patrickkaleta patrickkaleta added the on-hold Issue is on-hold and will be adressed later or closed label Oct 2, 2019
@p-a-s-c-a-l p-a-s-c-a-l added this to the D1.4 CLARITY CSIS v2 milestone Oct 2, 2019
@DenoBeno
Copy link
Author

DenoBeno commented Oct 2, 2019

I also agree that flat lists would probably work better for us now.

In the future, we should be able to lower the number of resources that need to be shown too, especially if/when we resolve teh clarity-h2020/data-package#47 and start showing only the resources that fit the users presets as defined in #101 and #108.

@DenoBeno
Copy link
Author

DenoBeno commented Oct 2, 2019

Closing this one, please continue discussion on clarity-h2020/clarity-theme#7

@DenoBeno DenoBeno closed this as completed Oct 2, 2019
@p-a-s-c-a-l p-a-s-c-a-l added the BB: Data Dashboard Data Dashboard Building Block label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BB: Data Dashboard Data Dashboard Building Block bug enhancement New feature or request on-hold Issue is on-hold and will be adressed later or closed question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants