-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow component declaration in VHDL blocks #2255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a purely functional POV. I've got a few engineering suggestions though.
Edit: Also usually I'd ask for a test, but I think we're implicitly going to do that for all cores in clash-cores
in the near future :).
I also noticed something I'd like to point out but I will do that tomorrow. |
369fcbe
to
09b97e9
Compare
Co-authored-by: Martijn Bastiaan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, curious what @DigitalBrains1 has to say!
I've rewritten with Alex's suggestions - I think this should be squashed when it is merged. |
This allows us to handle component declarations in VHDL blocks.
It it necessary for VHDL support for IP as we use it, see #2182 (comment)
Still TODO: