Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add burn tax exemption list #107

Merged
merged 23 commits into from
Feb 18, 2023
Merged

feat: add burn tax exemption list #107

merged 23 commits into from
Feb 18, 2023

Conversation

nghuyenthevinh2000
Copy link
Contributor

@nghuyenthevinh2000 nghuyenthevinh2000 commented Feb 9, 2023

Summary of changes

Backport to release 1.x, testing is written here:

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@nghuyenthevinh2000 nghuyenthevinh2000 changed the title add binance whitelist logic v1.x backport: add binance whitelist logic Feb 9, 2023
Copy link
Contributor

@ZaradarBH ZaradarBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

custom/auth/ante/burntax.go Outdated Show resolved Hide resolved
@inon-man inon-man self-requested a review February 12, 2023 01:18
@inon-man inon-man added enhancement New feature or request in scope Work approved by the community labels Feb 12, 2023
inon-man

This comment was marked as resolved.

@inon-man inon-man changed the base branch from release/v1.x to release/v2.x February 13, 2023 11:28
@inon-man inon-man changed the title v1.x backport: add binance whitelist logic v2.x backport: add binance whitelist logic Feb 13, 2023
@inon-man inon-man changed the base branch from release/v2.x to main February 13, 2023 11:37
@inon-man
Copy link
Collaborator

@nghuyenthevinh2000 I will update burntax, and burntax_test after #113

@inon-man inon-man changed the title v2.x backport: add binance whitelist logic feat: add binance whitelist logic Feb 13, 2023
@inon-man

This comment was marked as resolved.

@inon-man inon-man self-requested a review February 13, 2023 16:44
@inon-man inon-man added this to the v2.0.0 milestone Feb 13, 2023
@nghuyenthevinh2000

This comment was marked as resolved.

@nghuyenthevinh2000

This comment was marked as resolved.

@inon-man inon-man changed the title feat: add binance whitelist logic feat: add burn tax exemption list Feb 15, 2023
@inon-man

This comment was marked as resolved.

@inon-man
Copy link
Collaborator

@nghuyenthevinh2000 Could you also add a test for remove burn tax exemption list to burn-tax-exemption-test.sh?

@nghuyenthevinh2000
Copy link
Contributor Author

@nghuyenthevinh2000 Could you also add a test for remove burn tax exemption list to burn-tax-exemption-test.sh?

sure, I expect it should be the same

@nghuyenthevinh2000
Copy link
Contributor Author

@inon-man can you check again

Copy link
Collaborator

@inon-man inon-man left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inon-man inon-man merged commit ea02007 into main Feb 18, 2023
@inon-man inon-man deleted the v1.x/binance-whitelist branch February 18, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in scope Work approved by the community
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants