[experimental] Native file dragging plugin #1584
Conversation
🦋 Changeset detectedLatest commit: c681a00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "build:core": "tsup src/core/index.ts", | ||
| "build:modifiers": "tsup --entry.modifiers src/modifiers/index.ts", | ||
| "build:plugins": "tsup --entry.debug src/plugins/debug/index.ts --outDir ./plugins", | ||
| "build:draggableFile": "tsup --entry.draggableFile src/plugins/draggableFile/index.ts --outDir ./plugins", |
There was a problem hiding this comment.
Didn't take times figuring out how to configure the command. Put it here for now
This comment was marked as resolved.
This comment was marked as resolved.
yf-yang
changed the title
|
|
||
| if (!status.initialized || !shape) { | ||
| if (!status.initialized) { | ||
| return DEFAULT_VALUE; |
There was a problem hiding this comment.
It should be collision detection algorithm's responsibility to check shape's availability. File draggable does not have a shape and would be filtered by the original code implementation
| // Make sure effects will re-run when those properties change | ||
| void position.current; | ||
| void shape; | ||
|
|
There was a problem hiding this comment.
I don't know if it has a performance penalty (too many collisions recompute?)
|
@clauderic Can we discuss here or how can we get connected? Generally speaking, to support native file drop, I've make sure they can be handled by dnd kit, but the native dom event needs to be passed to dnd-kit event handlers (Particularly, 'drag' event needs to be passed to 'dragend' event) You can contact me on discord |
|
Hey can you help me better understand the use-case for this? I was considering introducing a native drag and drop plugin, for example, to allow drag and drop across windows, but I had not considered it for files. |
|
@clauderic It's simple: turning components to things like react-dropzone I've tested it with a local storybook (not pushed yet), the lifecycle events are correct (at least for simple cases), but the dataTransfer is not accessible when dropping, so it is incomplete. It's not the same with cross window drag and drop, as native dragging file is captured when it enters the window, but there isn't a programmable |
This PR aims at providing a plugin to drag and drop file from native fs to browser.
It is marked as draft because:
I don't know how to fix it. Would you consider passing the DOM event to core dnd-kit events (dragstart, dragend, dragmove...)?
fixes #1581