Merge upstream from coinbase's branch

.github/workflows/tests.yml

@@ -0,0 +1,85 @@
+name: Tests
+
+on:
+  push:
+    branches: [ "master" ]
+  pull_request:
+    branches: [ "master" ]
+
+jobs:
+  test_gem:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0.3
+          bundler-cache: true
+
+      - name: Run tests
+        run: |
+          bundle exec rspec
+
+  test_examples:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Start dependencies
+        run: |
+          docker compose \
+            -f examples/docker-compose.yml \
+            up -d
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.0.3
+
+      - name: Bundle install
+        run: |
+          cd examples && bundle install --path vendor/bundle
+
+      - name: Wait for dependencies to settle
+        run: |
+          sleep 10
+
+      - name: Register namespace
+        run: |
+          cd examples && bin/register_namespace ruby-samples
+
+      - name: Wait for namespace to settle
+        run: |
+          sleep 10
+
+      - name: Boot up worker
+        run: |
+          cd examples && bin/worker &
+
+      - name: Boot up crypt worker
+        env:
+          USE_ENCRYPTION: 1
+        run: |
+          cd examples && bin/worker &
+
+      - name: Boot up worker for v2 error serialization tests
+        env:
+          USE_ERROR_SERIALIZATION_V2: 1
+        run: |
+          cd examples && bin/worker &
+
+      - name: Run RSpec
+        env:
+          USE_ERROR_SERIALIZATION_V2: 1
+        run: |
+          cd examples && bundle exec rspec

CHANGELOG.md

@@ -1,4 +1,38 @@
 # Changelog
 
-## 0.0.1
-- First release
+## 0.1.1
+Allows signals to be processed within the first workflow task.
+
+**IMPORTANT:** This change is backward compatible, but workflows started
+on this version cannot run on earlier versions. If you roll back, you will
+see workflow task failures mentioning an unknown SDK flag. This will prevent
+those workflows from making progress until your code is rolled forward
+again. If you'd like to roll this out more gradually, you can,
+1. Set the `no_signals_in_first_task` configuration option to `true`
+2. Deploy your worker
+3. Wait until you are certain you won't need to roll back
+4. Remove the configuration option, which will default it to `false`
+5. Deploy your worker
+
+## 0.1.0
+
+This introduces signal first ordering. See https://github.com/coinbase/temporal-ruby/issues/258 for
+details on why this is necessary for correct handling of signals.
+
+**IMPORTANT: ** This feature requires Temporal server 1.20.0 or newer. If you are running an older
+version of the server, you must either upgrade to at least this version, or you can set the
+`.legacy_signals` configuration option to true until you can upgrade.
+
+If you do not have existing workflows with signals running or are standing up a worker service
+for the first time, you can ignore all the below instructions.
+
+If you have any workflows with signals running during a deployment and run more than one worker
+process, you must follow these rollout steps to avoid non-determinism errors:
+1. Set `.legacy_signals` in `Temporal::Configuration` to true
+2. Deploy your worker
+3. Remove the `.legacy_signals` setting or set it to `false`
+4. Deploy your worker
+
+These steps ensure any workflow that executes in signals first mode will continue to be executed
+in this order on replay. If you don't follow these steps, you may see failed workflow tasks, which
+in some cases could result in unrecoverable history corruption.

Gemfile

@@ -1,5 +1,5 @@
 source 'https://rubygems.org'
 
-gemspec
+gem 'google-protobuf', '~> 3.19'
 
-gem 'coveralls', require: false
+gemspec

Makefile

@@ -1,9 +1,9 @@
-PROTO_ROOT := proto/temporal
+PROTO_ROOT := proto
 PROTO_FILES = $(shell find $(PROTO_ROOT) -name "*.proto")
 PROTO_DIRS = $(sort $(dir $(PROTO_FILES)))
 PROTO_OUT := lib/gen
 
 proto:
 	$(foreach PROTO_DIR,$(PROTO_DIRS),bundle exec grpc_tools_ruby_protoc -Iproto --ruby_out=$(PROTO_OUT) --grpc_out=$(PROTO_OUT) $(PROTO_DIR)*.proto;)
 
-.PHONY: proto
+.PHONY: proto