add GitHub action for deploy of production service #1030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtomlinson
approved these changes
Feb 9, 2024
qtomlinson
reviewed
Feb 9, 2024
| }, | ||
| { | ||
| "name": "BUILD_SHA", | ||
| "value": "${{ github.sha }}", |
There was a problem hiding this comment.
May want to consider passing in env.DEPLOY_DOCKER_TAG, that is the semVer for production and github.sha for dev. Same on line 138.
There was a problem hiding this comment.
We can pass in the version in addition to the sha. I want the sha always available because it is the source of truth about what code has been deployed.
|
Closing. The action is being merged into prod instead of master. It will be back ported to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action is very similar to the dev action. The main differences are: