Swift6 compilation mode support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasbabulak
approved these changes
Feb 24, 2025
| publisher = newStream.publisher | ||
| } | ||
|
|
||
| guard let publisher else { return } |
There was a problem hiding this comment.
I assume, this should be considered as failure
Suggested change
| guard let publisher else { return } | |
| guard let publisher else { | |
| Issue.record("Should not be nil.") | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR provides support for Swift6 compilation mode. Fixes an issue where sending a
Sendablevalue to publisher was crashing the application due toDispatchQueue.mainprecondition - I found no way to make it work, not even initializing it on different Queue and then sending the value on that queue would help.