Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly Wait #24

Open
Triplemars opened this issue Jan 3, 2019 · 1 comment
Open

Implicitly Wait #24

Triplemars opened this issue Jan 3, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@Triplemars
Copy link

Hi

I see that you've implemented Explicit wait of Selenium.
I wanted to ask you why you didn't implement Implicit Wait, is there a problem you see to implement that?

I thought about adding the call to the implicitly wait after the condition of the wait until in line 88 in the middleware. Like this:

if request.wait_until: WebDriverWait(self.driver, request.wait_time).until( request.wait_until ) elif request.wait_time: self.driver.implicitly_wait(request.wait_time)

I like to hear what do you think about that

Thanks
@clemfromspace clemfromspace added the enhancement New feature or request label Nov 14, 2019
@SteveRyherd
Copy link

I was just looking for this!

nfk added a commit to nfk/scrapy-selenium that referenced this issue Jul 22, 2020
@nfk
Add a callback cb_selenium
55fdfb9 
This patch introduces 2 news parameters `cb_selenium` and `cb_selenium_kwargs`.
The purpose of the selenium callback is to init the webpage like the
scraper wants. In this callback you can use the webdriver to perform some
actions and wait a expected page state.

Refs: clemfromspace#24, clemfromspace#39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SteveRyherd @clemfromspace @Triplemars