Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update organization settings params to include admin_delete #134

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

mzhong9723
Copy link
Member

@mzhong9723 mzhong9723 commented May 31, 2023

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🌟 New feature (non-breaking change which adds functionality)
  • 🔨 Breaking change (fix or feature that would cause existing functionality)
  • 📖 Docs change / refactoring / dependency upgrade to change)

Description

Update SDK to include new admin_delete_enabled param for both organization settings and organizations

@mzhong9723 mzhong9723 requested a review from a team as a code owner May 31, 2023 20:51
@mzhong9723 mzhong9723 force-pushed the update-organization-settings branch 2 times, most recently from 0ada374 to 26b1a04 Compare June 1, 2023 05:35
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Tests will pass when you rebase on the latest main. 😄

Fixed in #130

@mzhong9723 mzhong9723 force-pushed the update-organization-settings branch from 26b1a04 to 66cc90e Compare June 5, 2023 02:34
@mzhong9723 mzhong9723 force-pushed the update-organization-settings branch from 66cc90e to 4207969 Compare June 5, 2023 02:42
@mzhong9723 mzhong9723 requested review from gkats, chanioxaris and a team June 5, 2023 02:50
@mzhong9723
Copy link
Member Author

@gkats @chanioxaris thanks for the reviews! re-requested since I updated the params for the update organizations (not just org settings) endpoints. We will need both of these for the dashboard work for self service delete project.

Copy link
Member

@chanioxaris chanioxaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mzhong9723 mzhong9723 merged commit 407eae7 into main Jun 5, 2023
@mzhong9723 mzhong9723 deleted the update-organization-settings branch June 5, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants