Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing user.CreateParams properties #371

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jan 21, 2025

The user.CreateParams struct was missing three (optional) properties which are supported by the CreateUser operation:

The user.UpdateParams struct already contains these properties.

@joschi joschi requested a review from a team as a code owner January 21, 2025 08:24
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition @joschi!

Left a comment about a struct field type. Could you please take a look? Thanks!

user/client.go Show resolved Hide resolved
@gkats gkats merged commit 26194ef into clerk:v2 Jan 21, 2025
5 checks passed
@joschi joschi deleted the user-create-params branch January 22, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants