pandoc is required, enhances #20 #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brief link to pandoc install instructions to support html2text
|
Hi @jeffbryner, could you please add to the |
remusao
reviewed
Jun 2, 2017
| @@ -35,7 +35,12 @@ package in 'developer mode' using `pip`, in a virtual environment. You also need | |||
| ```sh | |||
| $ pip install -e . | |||
| ``` | |||
| ## Prerequisites | |||
| You'll need: | |||
| - pandoc: http://pandoc.org/installing.html | |||
There was a problem hiding this comment.
Actually, we don't really need pandoc anymore. So we can probably remove it altogether from the README + setup.py. phantomjs should be enough currently.
There was a problem hiding this comment.
oh, it prompted when trying to install pypandoc. Is pypandoc not needed?
There was a problem hiding this comment.
Not at the moment. We used it at the beginning to convert privacy policies to github markdown but disabled this feature temporarily. We might do it again when we have a better cleaning process for the policies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief link to pandoc install instructions to support html2text
Supports issue #20