Support async Ring #10
Conversation
camsaul
force-pushed
the
support-async-ring
branch
2 times, most recently
from
9a32b9e to
f0b93a2
Compare
src/ring/middleware/gzip.clj
Outdated
| (gzipped-response resp) | ||
| resp)) | ||
| resp)))) | ||
| (defn- wrap-gzip* [req {:keys [body status] :as resp}] |
There was a problem hiding this comment.
Can you change this to gzip-request please?
There was a problem hiding this comment.
No problem. Would gzip-response make more sense? Because it's the response that's getting zipped, not the request. In the JSON middleware you linked they're going with json-response for the function that does the same thing
There was a problem hiding this comment.
Sorry, yes you're completely right.
src/ring/middleware/gzip.clj
Outdated
| ([request respond raise] | ||
| (handler | ||
| request | ||
| (comp respond (partial wrap-gzip* request)) |
There was a problem hiding this comment.
Can you make this match the style at https://github.com/ring-clojure/ring-json/blob/0.5.0-beta1/src/ring/middleware/json.clj#L125? Composing multiple functions like this is not that easy to understand immediately.
src/ring/middleware/gzip.clj
Outdated
| (fn | ||
| ([request] | ||
| (wrap-gzip* request (handler request))) | ||
|
|
There was a problem hiding this comment.
Can you remove the space between arities?
|
@danielcompton made the changes you requested and added a test as well. Let me know if this works for you |
danielcompton
force-pushed
the
support-async-ring
branch
from
d9a2cce to
fa5057e
Compare
|
Released in 0.1.4. |
Minor tweaks to the middleware so it will can be used with either a 3-airty async handler (added in Ring 1.6.0) or with a 1-arity synchronous handler.