Conditional Reader macro on var definitions error

[leoiacovini]

version
2021.09.25

platform

Using from clojure-lsp

editor

Using from clojure-lsp + calva

problem

clj-kondo seems to not parse properly metadata on vars definition that contains the Conditional Reader macro. Depending on the syntax it can go from making the namespace unparsable and the var not identified, to just not being made available for clj-kondo analysis afterward.

repro

1. First case we get the following error: missing value for key #?@ (:clj [:deprecated "deprecation message"])

(def ^{#?@(:clj [:deprecated "deprecation message"])}
  my-deprecated-var
  :bla)

2. Second error the var is parsed, but it is not marked as deprecated in the following usages:

(def ^#?(:clj {:deprecated "deprecation message"})
  my-deprecated-var
  :bla)

expected behavior

I would expect the code to be parsed correctly and the var would be displayed as deprecated when used inside the clj environment, but not on the cljs

[borkdude]

@leoiacovini Fixed on master. Note that your second case doesn't work in CLJS: it also needs a :cljs or :default with an empty map there.

[borkdude]