Handling of reader conditional after ^

[sogaiu]

version

clj-kondo v2020.07.30-SNAPSHOT 2fb6175

platform

Linux, native-image (locally built)

problem

Reader conditional appearing after ^ appears to lead to an error.

To be specific, code like:

^#?(:clj :a :cljr :b) [:smile]

yields an error via a clj-kondo with the above version like:

error: keyword :clj is called with 3 args but expects 1 or 2

In the wild, some examples of code that trigger this can be seen at:

• https://github.com/chourave/diff/blob/3ed3297af492c6d439de9dda964992cb254b6a29/src/plumula/diff.cljc#L45-L48
• https://github.com/mikera/core.matrix/blob/cdfd84009b796141feddc41b7dee3681c5c238ca/src/main/clojure/clojure/core/matrix/impl/persistent_vector.cljc#L64

repro.cljc:

(ns my.ns)

^#?(:clj :a :cljr :b) [:smile]

output of clj-kondo --lint repro.cljc:

repro.cljc:3:11: error: keyword :clj is called with 3 args but expects 1 or 2
linting took 27ms, errors: 1, warnings: 0

expected behavior

The expected behavior is to not report an error as the construct appears to be correct in Clojure.

related

Related issue in parcera: carocad/parcera#80

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[borkdude]

#785 and this one seem to be duplicates?

[sogaiu]

Oh may be so. Sorry about that!

[borkdude]

No worries. Feel free to close one of your liking :)

[borkdude]

@sogaiu This has already been fixed in a previous release of clj-kondo. Please report if you find that this isn't the case with the newest version of clj-kondo.

[sogaiu]

@borkdude I tried with 89544bd but still get the same output:

$ clj-kondo --lint -
^#?(:clj :a :cljr :b) [:smile]
<stdin>:1:4: error: keyword :clj is called with 3 args but expects 1 or 2
linting took 3548ms, errors: 1, warnings: 0

$ clj-kondo --version
clj-kondo v2021.12.02-SNAPSHOT

This was with a local build -- perhaps I didn't get that right or messed up in some other way...

[borkdude]

You need to set either lang cljc or lint a cljc file.

On Thu, 16 Dec 2021 at 00:58, sogaiu ***@***.***> wrote: @borkdude <https://github.com/borkdude> I tried with 89544bd <89544bd> but still get the same output: $ clj-kondo --lint - ^#?(:clj :a :cljr :b) [:smile] <stdin>:1:4: error: keyword :clj is called with 3 args but expects 1 or 2 linting took 3548ms, errors: 1, warnings: 0 $ clj-kondo --version clj-kondo v2021.12.02-SNAPSHOT This was with a local build -- perhaps I didn't get that right or messed up in some other way... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#970 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACFSBRTEZWV22YDQR7GOULURETTLANCNFSM4QLFXQLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- https://www.michielborkent.nl https://www.eetvoorjeleven.nu

[sogaiu]

Ah right. Thanks! I never seem to learn that :)

Ok, this is what I get now:

$ clj-kondo --lang cljc --lint -
^#?(:clj :a :cljr :b) [:smile]
<stdin>:0:0: error: Can't parse <stdin>, No implementation of method: :sexpr of protocol: #'clj-kondo.impl.rewrite-clj.node.protocols/Node found for class: nil
linting took 9255ms, errors: 1, warnings: 0

Interestingly, it works for the following:

$ clj-kondo --lang cljc --lint -
^#?(:clj :a :cljs :b) [:smile]
linting took 16166ms, errors: 0, warnings: 0

So may be it's because of :cljr?

I guess that's a different thing then.

[borkdude]

Can reproduce with :cljr, thanks.

[borkdude]

Fixed on master.