Skip to content

Commit

Permalink
Revert loading the data-readers
Browse files Browse the repository at this point in the history 
Apparently this causes an exception in boot (precisely the system this
fix was for).
clojure-emacs/cider#1462 remains open.

Exception message: https://clojurians.slack.com/archives/cider/p1455501034000003

    ERROR: Unhandled REPL handler exception processing message {:op init-debugger, :print-level 10, :print-length 10, :session f10681b1-e8f4-48c6-bbc9-869f5ec1d54a, :id 7}
    java.lang.IllegalStateException: Can't set!: *data-readers* from non-binding thread
  • Loading branch information
@Malabarba
Malabarba committed Feb 15, 2016
1 parent 2226f51 commit ebf3526
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/cider/nrepl/middleware/debug.clj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,6 @@
[{:keys [print-length print-level] :as msg}]
(when (map? @debugger-message)
(debugger-send :status :done))
;; Workaround for https://github.com/clojure-emacs/cider/issues/1462
(#'clojure.core/load-data-readers)
(set! *data-readers* (.getRawRoot #'*data-readers*))
;; The above is just bureaucracy. The below is important.
(reset! @#'print-length print-length)
(reset! @#'print-level print-level)
Expand Down

2 comments on commit ebf3526

@sanjayl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to push this version to clojars when you get a chance?
I had the same situation with lein BTW, but only when working within the cider-nrepl project; debugging still worked as expected in other projects.

PS, thanks for the debugger, it's amazing!

@Malabarba
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, later tonight.

Please sign in to comment.