Send the complete ns form in interactive eval requests

[cichli]

Fixes #1026.

See CLJS-1139 - ns forms are not currently additive in ClojureScript REPLs, so until that's fixed, I think we should send the full form.

This was previously changed to send the full form in #807 and then changed back in #814 - I can confirm that the latter has not regressed from this change.

AFAIK the only possible side-effect from this would be the:reload / :reload-all options, which we already remove.

cc @vspinu - does this sound reasonable?

[bbatsov]

See CLJS-1139 - ns forms are not currently additive in ClojureScript REPLs, so until that's fixed, I think we should send the full form.

Yes.

This was previously changed to send the full form in #807 and then changed back in #814 - I can confirm that the latter has not regressed from this change.

Yeah, we were incorrectly believing the ns forms weren't additive; turned out we had another problem.

While we're on this, you might also comment the logic in the function a bit. If it's confusing to you I can imagine few people would normally understand what are we doing here. :-)

[vspinu]

Oh. We have been dancing around this for at least half a year now. #830 and #956 are behind the most recent code change.

@cchili Could you please just comment those two lines and reference all the relevant issues in the comment? Thanks.

[cichli]

Yeah, I'll add some notes to the code now. FWIW I see little-to-no performance difference between cider-eval-last-sexp and cider-eval-defun-at-point (the former using plain eval and the latter using load-file with the full ns declaration), so it seems performance is no longer an issue. Certainly neither is taking 1-2 seconds even for a big ns declaration.

[cichli]

Hang on, don't merge this yet...