Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+Region/Zone] Implement GetRegionZone() to Azure Cloud Driver #933

Merged
merged 2 commits into from
Sep 22, 2023
Merged

[+Region/Zone] Implement GetRegionZone() to Azure Cloud Driver #933

merged 2 commits into from
Sep 22, 2023

Conversation

ish-hcc
Copy link
Member

@ish-hcc ish-hcc commented Sep 22, 2023

Azure

  • Implement GetRegionZone()
  • Speed up ListRegionZone() from about 10sec to 5sec.

@powerkimhub powerkimhub self-requested a review September 22, 2023 10:29
@powerkimhub powerkimhub linked an issue Sep 22, 2023 that may be closed by this pull request
[+Region/Zone] Azure Cloud Driver Implementation #913
Closed
powerkimhub
powerkimhub approved these changes Sep 22, 2023
View reviewed changes
cloud-control-manager/cloud-driver/drivers/azure/resources/RegionZoneHandler.go
wait.Add(routineMax)

for j := 0; j < routineMax; j++ {
go func(wait *sync.WaitGroup, loc subscriptions.Location) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fetch 성능 개선을 위해서 next 작업 예정이었는데,
  • 선행 해주셨네요^^

@powerkimhub powerkimhub merged commit c8b4908 into cloud-barista:master Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerkimhub powerkimhub powerkimhub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[+Region/Zone] Azure Cloud Driver Implementation
2 participants
@ish-hcc @powerkimhub