Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CF binary name override #70

Merged
merged 22 commits into from
Aug 24, 2023
Merged

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Closes #69

On Windows command prompts, the cf CLI binary can only be referenced as cf7 or cf8. These changes allow plugin users to override the binary name used when creating tunnels for those environments.

Also included:

  • Setting up pipeline for automated releases
  • Bump plugin version to 1.1.3

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@markdboyd markdboyd requested a review from a team August 24, 2023 14:19
@markdboyd markdboyd merged commit 8cb2908 into main Aug 24, 2023
@markdboyd markdboyd deleted the allow-cf-binary-name-override branch August 24, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding the binary name used for creating the SSH tunnel
2 participants