Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use files from git resource #82

Merged
merged 2 commits into from
Jul 10, 2024
Merged

use files from git resource #82

merged 2 commits into from
Jul 10, 2024

Conversation

dandersonsw
Copy link
Contributor

Changes proposed in this pull request:

  • Use the files from the git resource to populate the name, tag, and commitish params
  • Remove tag file

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Use the files already generated by the resource rather than setting a file ourselves

@dandersonsw dandersonsw requested a review from a team as a code owner July 10, 2024 21:16
@dandersonsw dandersonsw merged commit a0b715d into main Jul 10, 2024
@dandersonsw dandersonsw deleted the update-refs branch July 10, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants