Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add CODEOWNERS #590

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: add CODEOWNERS #590

wants to merge 3 commits into from

Conversation

bengerman13
Copy link
Contributor

Changes proposed in this pull request:

  • Add CODEOWNERS

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

Having a codeowners helps us follow our processes, which helps improve security

@bengerman13 bengerman13 requested a review from a team January 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweibel cweibel cweibel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengerman13 @cweibel