-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdf migrations #21
pdf migrations #21
Conversation
acd4eb1
to
5355e71
Compare
PDFs make me sad. Would muuuuch rather see these converted to HTML with a redirect from that path. This meets OMB M-23-22 guidance. What do we gain by checking in these PDFs? |
26e9a85
to
db8d87e
Compare
I don't have an answer or opinion on that. That said, if we're going to do this as a feature upgrade, I would prefer to create a new ticket outside of this epic to approach that upgrade. That way we can specify both requirements and acceptance criteria without muddying the migration effort and both can have acceptance criteria. Then we can define things like PDF style guides, headers, etc. and someone on the team can have a clearly defined goal. |
Converting PDFs to HTML pages was always on the list of things that needed to happen for this work, as I described it a while back:
Either we do it now or we do it later/soon, but all PDF content needs to be remediated to HTML if we want to be compliant on this site. Can you scope how long it would take you to get a fair web experience up for this as a collection in HTML, not PDF? I understand the designs wouldn't be 1-1. Can you make an estimate of how long it would take and what state the content would be in, in terms of quality of experience?
Do you mean like... re-export the PDFs with a consistent style? OR just how the content that is currently in PDFs ends up in HTML? |
db8d87e
to
9ae0122
Compare
@sknep we don't have a functionality currently to redirect from the old PDFs to the new HTML page. Can we create the HTML representations of the old PDFs and leave the PDFs for now while we think about how we could accomplish it? |
For today, do we want to just copy PDF text content out and put in a file /resources/{original-file-name-without-extension}? For unlinked files, just delete them? |
Let's try with a meta refresh / redirect and see if the mimetypes mess it up: https://www.sitebuilderone.com/blog/11ty-url-redirections.html |
Revised: Won't be doing PDF -> HTML/MD conversions for now. Will:
|
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /assets/documents/Office_Hours_EC_ES_Tech_Talk.pdf/index.html | |||
redirect: /docs/overview/customer-service-objectives/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets redirect this one to: https://cloud.gov/docs/services/aws-elasticache/
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /assets/documents/cloudgov-vendors-2019.pdf/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://cloud.gov/assets/documents/cloudgov-vendors-2019.pdf
doesnt' exist.... is this the right source URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the permalink should say:
permalink: /resources/cloudgov-vendors-2019.pdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the permalink. Good catch! Where should the redirect go?
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /assets/documents/federalist-system-architecture.pdf/index.html | |||
redirect: /pages/documentation/how-pages-works/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking about this one in slack. It might already exist somewhere else, like on our diagrams site at https://diagrams.fr.cloud.gov/
@@ -0,0 +1,5 @@ | |||
--- | |||
permalink: /assets/documents/how-federalist-works-for-presentation.pdf/index.html | |||
redirect: /pages/documentation/how-pages-works/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this redirect to the PDF you're including at:
_assets/documents/how-pages-works-diagram.pdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure honestly. We can delete how-pages-works-diagram.pdf and redirect to /pages/documentation/how-pages-works/. For how-federalist...pdf, this was just a best guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, federalist is the old name of Pages, so i think it has just been replaced by newer content 2x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should definitely delete this one! no redirect! into the ether!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's delete and redirect this one to https://cloud.gov/pages/success-stories/#afwerx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's delete this one and redirect to https://cloud.gov/pages/documentation/security-and-compliance/
_assets/documents/Pages-Proposal.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's delete and redirect this one to the pages homepage, cloud.gov/pages
_assets/documents/afwerx-success.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's delete and redirect this one to https://cloud.gov/pages/success-stories/#afwerx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets delete and redirect to https://cloud.gov/pricing/
_assets/documents/coe-success.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_assets/documents/doi-success.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these diagrams might not have a good replacement, in which case a ticket for me to rebuild them in something accessible is the right call. do you know where these are used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this is the only place they're referenced: https://cloud.gov/docs/compliance/diagrams/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect this to get closed soon, so we can keep this diagram for now. When that ticket is addressed, we can come back to this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is shippable!
btw next time -- feel free to dismiss and re-request reviews if you're waiting to hear back, I didn't realize you were done and waiting on me
Changes proposed in this pull request: