Callbacks for blocked/unblocked notifications #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the server is out of disk or RAM it might notify its clients. Prevoiusly we blocked all writes but that also made it impossible to send Ack/Reject frames when consuming for instance, which made so that the server might not recoup disk space or RAM when the queue was shrinking. Connection#on_blocked and Connection#on_unblocked callbacks are now added so that the user can stop only publishing when the server is blocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the server is out of disk or RAM it might notify its clients. Prevoiusly we blocked all writes but that also made it impossible to send Ack/Reject frames when consuming for instance, which made so that the server might not recoup disk space or RAM when the queue was shrinking.
Connection#on_blocked and Connection#on_unblocked callbacks are now added so that the user can stop only publishing when the server is blocked.