Make channel raise Connection::ClosedException
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spuun
force-pushed
the
make-channel-raise-connection-closedexception
branch
from
18f686b to
881c556
Compare
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
kickster97
approved these changes
Aug 23, 2024
snichme
approved these changes
Aug 23, 2024
spuun
force-pushed
the
make-channel-raise-connection-closedexception
branch
from
ad835a0 to
281318c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
Channel#basic_consumewithblock = truedidn't raise any exception if the connection was closed by the broker, the method just returned. This because we only checked if the channel had been closed, not the connection.This will add check that the connection hasn't been closed in every place where we checked if the channel has been closed, and if the connection has been closed a
Connection::ClosedExceptionwill be raised.I've added a few specs, but not all cases are covered.