Adding Set-SystemInfo for Windows #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fabi200123
commented
May 27, 2024
•
fabi200123
commented
- Adding Set-SystemInfo for Windows
cloudconfig/templates.go
Outdated
| @@ -393,6 +393,49 @@ function Invoke-GarmFailure() { | |||
| } | |||
| } | |||
|
|
|||
| function Get-SystemInfo { | |||
There was a problem hiding this comment.
Just a small nit: Rename this to Set-SystemInfo. We're setting the system info in the GARM API, because we're sending the payload as part of this function. The Get verb is meant for functions that fetch information and present it as a return value. This sets something in a remote system. It never returns anything.
fabi200123
force-pushed
the
get-systeminfo
branch
from
45d47b3 to
bbf1987
Compare
fabi200123
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.