Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests #13

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Adding unit tests #13

merged 1 commit into from
Mar 11, 2024

Conversation

fabi200123
Copy link
Contributor

  • Adding unit tests for the provider

@gabriel-samfira
Copy link
Member

Could you also add a github workflow to run these tests?

@fabi200123
Copy link
Contributor Author

Sure thing! Adding one now!

@fabi200123 fabi200123 force-pushed the unit-tests branch 2 times, most recently from cdf4353 to e076f98 Compare March 6, 2024 09:39
- run: go version

- name: Run GARM Go Tests
run: make go-test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the makefile. Or you could just call go test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the Makefile now

@gabriel-samfira
Copy link
Member

Let me know when this is no longer a WiP.

@fabi200123 fabi200123 force-pushed the unit-tests branch 2 times, most recently from 39325f0 to 39d25b5 Compare March 8, 2024 13:28
@fabi200123 fabi200123 changed the title [WIP] Adding unit tests Adding unit tests Mar 11, 2024
@gabriel-samfira gabriel-samfira merged commit 0a2ba2f into cloudbase:main Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants