Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query() method of ValidatedRequest should have same interface as Illuminate\Http\Request #440

Conversation

jelhan
Copy link
Contributor

@jelhan jelhan commented Oct 15, 2019

This adds support for retrieving a specific query param with a default value:

$validatedRequest->query('name', 'Helen');

More information about that feature available in Laravel docs:
https://laravel.com/docs/5.8/requests#retrieving-input

It is available for all supported Laravel versions (5.5 and above).

…minate\Http\Request

This adds support for retrieving a specific query param with a default value:
$validatedRequest->query('name', 'Helen');

More information about that feature available in Laravel docs:
https://laravel.com/docs/5.8/requests#retrieving-input

This feature is available for all supported Laravel versions (5.5 and above).
Copy link
Contributor

@jstoone jstoone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

@lindyhopchris
Copy link
Member

Agreed, looks good - thanks for submitting!

For 2.0 I'm hoping to extend the form request directly, which will mean the standard Laravel methods will be there, which will hopefully be an improvement!

@lindyhopchris lindyhopchris merged commit 26e4355 into cloudcreativity:develop Oct 15, 2019
@jstoone
Copy link
Contributor

jstoone commented Oct 23, 2019

Oh yess, that would be amazing @lindyhopchris. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants