Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: tfcheck dependency update with versionEvaluate #115

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Feature: tfcheck dependency update with versionEvaluate #115

merged 5 commits into from
Jan 10, 2024

Conversation

themaniskshah
Copy link
Member

@themaniskshah themaniskshah commented Jan 8, 2024 •
edited
Loading

what

  • Updated auto-merge steps name
  • tfcheck's format dependency update with versionEvaluate

why

  • tfcheck steps requires for the auto-merge workflow. we need static value to pass in on the auto-merge after all the checks pass. so we assigned a format step with needs: [versionExtract, versionEvaluate] after that we can use the format step in the auto-merge workflow. so we don't need to change in the future.

@themaniskshah themaniskshah requested a review from a team January 8, 2024 09:30
VishwajitNagulkar
VishwajitNagulkar previously approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaibhav7797
vaibhav7797 approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@themaniskshah themaniskshah enabled auto-merge (squash) January 10, 2024 16:59
@themaniskshah themaniskshah merged commit 077e955 into master Jan 10, 2024
1 check passed
@themaniskshah themaniskshah deleted the feature/dependabot-02 branch January 10, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhav7797 vaibhav7797 vaibhav7797 approved these changes

@anmolnagpal anmolnagpal anmolnagpal approved these changes

@VishwajitNagulkar VishwajitNagulkar VishwajitNagulkar left review comments

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@themaniskshah @anmolnagpal @vaibhav7797 @VishwajitNagulkar