Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/update #77

Merged
merged 11 commits into from
Jan 29, 2025
Merged

Feat/update #77

merged 11 commits into from
Jan 29, 2025

Conversation

Tanishdrove
Copy link
Member

what

  • Added the support of skipping the creation of subnet_nsg_association
  • Added the support of adding network_interface_nsg_association

why

  • Previously skipping the association of nsg with subnet was impossible
  • There was no support of nic_nsg association

@Tanishdrove Tanishdrove added the enhancement New feature or request label Jan 20, 2025
@Tanishdrove Tanishdrove self-assigned this Jan 20, 2025
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output 



      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        

  

      

  13archit
  

  
          

            
                  13archit
  

            

            reviewed


            
                
                  Jan 21, 2025
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
      

            

          
                main.tf

              
                Outdated
          
            Show resolved
            Hide resolved
        


    
          
            
  
    
    

          



  








  








      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        

  

      

  13archit
  

  
          

            
                  13archit
  

            

            reviewed


            
                
                  Jan 21, 2025
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
      

            

          
                outputs.tf

              
                Outdated
          
            Show resolved
            Hide resolved
        


    
          
            
  
    
    

          



  








  








      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
        





      

  
      



  

  @clouddrove-ci





  


    

      

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
  Member


      

  


  

    

  





      


        


  
    

      
          
Terraform Security Scan Failed


Show Output




      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  
  

  
      @13archit
  13archit


          self-requested a review


    January 21, 2025 19:43    
    









      

  
        





      

  
          

  

    
  

  


        
        @13archit
  13archit



        merged commit 2a32893
      into

      
  
    master
  


    Jan 29, 2025

      

        19 checks passed
      


      

        
          
  
    
    

        
      

  
















  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @13archit
  
    13archit



          
            
              
            
          
          13archit approved these changes

        

      

          

  
      @d4kverma
  
    d4kverma


                Awaiting requested review from d4kverma


        
      


      






    

  


      
  

    Assignees
  



        

      

        

  
      @Tanishdrove
  
    Tanishdrove
    

      








      


  


  

    Labels
  



    

      

    enhancement

  New feature or request








      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    
      

        
    

    Development
  



          


Successfully merging this pull request may close these issues.



  


    
  




      

    

  
      

  

    

      3 participants
    

    

        
          @Tanishdrove 
        
          @clouddrove-ci 
        
          @13archit