move parameterOrder order declaration closer to use

cloudendpoints · Feb 16, 2018 · 8794cce · 8794cce
1 parent b09cd32
commit 8794cce
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/...oints-framework/src/main/java/com/google/api/server/spi/discovery/DiscoveryGenerator.java b/...oints-framework/src/main/java/com/google/api/server/spi/discovery/DiscoveryGenerator.java
@@ -222,14 +222,14 @@ private void writeApiMethod(ApiConfig config, String servicePath, RestDescriptio
   private List<String> computeParameterOrder(ApiMethodConfig methodConfig) {
     ImmutableSortedSet.Builder<String> queryParamBuilder = ImmutableSortedSet.naturalOrder();
     Collection<String> pathParameters = methodConfig.getPathParameters();
-    List<String> order = new ArrayList<>(pathParameters);
     for (ApiParameterConfig parameterConfig : methodConfig.getParameterConfigs()) {
       if (parameterConfig.getClassification() == Classification.API_PARAMETER
           && !pathParameters.contains(parameterConfig.getName())
           && !parameterConfig.getNullable()) {
         queryParamBuilder.add(parameterConfig.getName());
       }
     }
+    List<String> order = new ArrayList<>(pathParameters);
     order.addAll(queryParamBuilder.build());
     return order;
   }