-
Notifications
You must be signed in to change notification settings - Fork 35
Add description on enum constants #133
Add description on enum constants #133
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
I'm ok with my commits being contributed to this project. |
Looks like merging the other PR puts this in conflict. Please fix. |
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage ? 79.86%
Complexity ? 1662
=========================================
Files ? 156
Lines ? 5568
Branches ? 716
=========================================
Hits ? 4447
Misses ? 843
Partials ? 278
Continue to review full report at Codecov.
|
@tangiel The merge includes the fix for the currently failing master. |
for (Object enumConstant : type.getRawType().getEnumConstants()) { | ||
builder.addEnumValue(enumConstant.toString()); | ||
builder.addEnumDescription(""); | ||
.setName(Types.getSimpleName(type, config.getSerializationConfig())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for changing this indent?
@@ -0,0 +1,27 @@ | |||
/* | |||
* Copyright 2016 Google Inc. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put 2018 here.
This PR allows to set a description on enum values in API method parameters, as allowed in the discovery format.
PS: we tried to implement description for enums in Swagger here, as described in Swagger documentation for enums, using the description field, but we preferred not to include it yet.