Gracefully handle df errors when Dataflow not enabled on CDP tenant #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Enright <[email protected]>
wmudge
approved these changes
Apr 7, 2022
There was a problem hiding this comment.
Approved, but you can drop the field parameter in the Squelch objects because the parameter defaults to error_code. See https://github.com/cloudera-labs/cdpy/blob/devel/src/cdpy/common.py#L121
If you want to make these changes before I commit, go ahead. Otherwise, we can clean up in a subsequent PR.
Signed-off-by: Jim Enright <[email protected]>
Thanks @wmudge - I've made that suggested change. |
wmudge
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Squelch to catch
PATH_DISABLEDerror code that is returned when Dataflow entitlement is not enabled.For completeness added to the following methods:
list_servicesdescribe_servicelist_deploymentsdescribe_deploymentlist_readyflowslist_flow_definitionsdescribe_readyflowimport_readyflowdelete_added_readyflowdescribe_added_readyflowdescribe_customflowSigned-off-by: Jim Enright [email protected]