Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle StaticCredentials #63

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Handle StaticCredentials #63

merged 2 commits into from
Mar 6, 2023

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Mar 6, 2023

Handle Cdpy() and submodule use of StaticCredentials, i.e. direct credential assignment.

@wmudge
Add basic test
0fe8ba9 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge wmudge added the enhancement New feature or request label Mar 6, 2023
@wmudge wmudge requested a review from jimright March 6, 2023 19:22
jimright
jimright approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Tested with tox run and manually running tests to confirm that both static creds and discovered creds work correctly. Approved.

@wmudge wmudge merged commit 3ca9a72 into cloudera-labs:devel Mar 6, 2023
@wmudge wmudge deleted the feature/static-credentials branch March 6, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimright jimright jimright approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmudge @jimright