Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix globals for aws #78

Draft
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

Chaffelson
Copy link
Collaborator

AWS region is the default region for AWS, and now moved to top of the AWS specific section
AWS profile is a globals option and moved into the globals section

Note that common__aws_region is the default region for AWS deployments, similar to common__azure_region and common__gcp_region

AWS region is the default region for AWS, and now moved to the AWS specific section
AWS profile is a globals option and moved into the globals section

Signed-off-by: Daniel Chaffelson <[email protected]>
@Chaffelson Chaffelson requested a review from wmudge December 8, 2021 12:31
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update configuration.yml too

@wmudge wmudge added the enhancement New feature or request label Mar 31, 2022
@wmudge wmudge added this to the Version 1.7 milestone Apr 6, 2022
@wmudge wmudge marked this pull request as draft November 15, 2022 16:25
@wmudge wmudge removed this from the Version 1.7 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants