Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a null check Fix issue #24 #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,12 @@ public boolean check(Row row) {
boolean check = true;
for (String field : fields) {
String value = row.getAs(field);
Matcher matcher = pattern.matcher(value);
check = check && matcher.matches();
if (value != null) {
Matcher matcher = pattern.matcher(value);
check = check && matcher.matches();
} else {
check = false;
}
if (!check) {
// No point continuing if failed
break;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ public void testNameRegex() {

Row row4 = new RowWithSchema(SCHEMA, "First Last", "Ian Last", 110, new BigDecimal("450.10"));
assertTrue("Row should pass rule", rule.check(row4));

Row row5 = new RowWithSchema(SCHEMA, null, null, 110, new BigDecimal("450.10"));
assertFalse("Row 5 should not pass rule", rule.check(row5));
}

}