Azure pre-reqs module and refactor for CDP deploy modules #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
wmudge
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Tried running modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs and it failed. I filled out the terraform.tfvars as required.
wmudge@wmudge-mbp16-21580:~/tmp/2021-07-13/terraform-cdp-modules/modules/terraform-cdp-aws-pre-reqs/examples/ex01-minimal_inputs % terraform apply [pr-20] [10302] 14:41:28
╷
│ Error: Unsupported argument
│
│ on main.tf line 26, in module "ex01_minimal_inputs":
│ 26: aws_key_pair = var.aws_key_pair
│
│ An argument named "aws_key_pair" is not expected here.
╵
modules/terraform-cdp-deploy/examples/ex01-aws-basic/terraform.tfvars.sample
Outdated
Show resolved
Hide resolved
modules/terraform-cdp-deploy/examples/ex02-azure-basic/terraform.tfvars.sample
Outdated
Show resolved
Hide resolved
modules/terraform-cdp-deploy/examples/ex01-aws-basic/terraform.tfvars.sample
Outdated
Show resolved
Hide resolved
Signed-off-by: Jim Enright <[email protected]>
Signed-off-by: Jim Enright <[email protected]>
Hi @wmudge, Apologies, I had not updated the examples for the terraform-cdp-aws-pre-reqs module on its own. This is done now and ready for re-test. |
Signed-off-by: Jim Enright <[email protected]>
|
I have tested the AWS part of the examples, works on my side. |
dennaloh
pushed a commit
to dennaloh/terraform-cdp-modules
that referenced
this pull request
Jan 20, 2025
…abs#20) Signed-off-by: Jim Enright <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform-cdp-azure-pre-reqsfor the creation of the pre-requisite Azure cloud resourcesterraform-cdp-deployto handle the deployment of Cloudera Data Platform (CDP) Public Cloud environment and Datalake creationterraform-cdp-aws-pre-reqsmodule to move the CDP creation to the newterraform-cdp-deploymodule.NOTE: CDP deployment is still carried out via Ansible Playbooks and the cloudera.cloud Ansible collections.