Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS pre-reqs IAM resources for multi-bucket support #44

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Dec 1, 2023

We found that various changes to the IAM policies and role attachments in the AWS pre-reqs module are required when using separate buckets for Log, Data and Backup storage.

  • The CDP bucket access policy needs to have each bucket specified in the resource section
    • In this PR we achieve this by creating a separate bucket access policy if the log and/or backup bucket location are different to the data bucket.
  • The CDP log role should include the backup policy

Additionally, we found that the code had a unnecessary attachment of the bucket access policy to the log role. This is removed in the PR.

@jimright jimright added the enhancement New feature or request label Dec 1, 2023
@jimright jimright requested a review from balazsgaspar December 1, 2023 17:54
@balazsgaspar
Copy link
Contributor

@jimright We might need the same changes for Azure (separate storage account containers / separate storage accounts for data/log/backup)

@jimright
Copy link
Contributor Author

@jimright We might need the same changes for Azure (separate storage account containers / separate storage accounts for data/log/backup)

Hi @balazsgaspar,

Yes! I believe that Azure deployment will work with separate storage containers but will test this and make any updates if needed.

@jimright jimright merged commit 37fc2b1 into cloudera-labs:main Dec 18, 2023
3 checks passed
dennaloh pushed a commit to dennaloh/terraform-cdp-modules that referenced this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants