CDPCP-12516 - clean up unused functions prior implementing dead code …

…check
cloudera · Jul 24, 2024 · eb9b671 · eb9b671
1 parent a42ba6d
commit eb9b671
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 131 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -100,7 +100,7 @@ jobs:
       - name: Go Coverage
         uses: gwatts/[email protected]
         with:
-          coverage-threshold: 32.0
+          coverage-threshold: 31.9
           cover-pkg: ./...
           ignore-pattern: |
             /cdp-sdk-go/ 

diff --git a/cdp-sdk-go/cdp/errors.go b/cdp-sdk-go/cdp/errors.go
@@ -11,21 +11,16 @@
 package cdp
 
 import (
+	"strings"
+
 	datahubmodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/datahub/models"
 	datalakemodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/datalake/models"
 	environmentsmodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/environments/models"
-	iammodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/iam/models"
-	mlmodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/ml/models"
 	opdbmodels "github.com/cloudera/terraform-provider-cdp/cdp-sdk-go/gen/opdb/models"
-	"strings"
 )
 
 // These functions should be generated in the appropriate gen package in an errors module.
 
-func IsIamError(err *iammodels.Error, code string, message string) bool {
-	return err.Code == code && strings.Contains(err.Message, message)
-}
-
 func IsEnvironmentsError(err *environmentsmodels.Error, code string, message string) bool {
 	return err.Code == code && strings.Contains(err.Message, message)
 }
@@ -41,7 +36,3 @@ func IsDatahubError(err *datahubmodels.Error, code string, message string) bool
 func IsDatabaseError(err *opdbmodels.Error, code string, message string) bool {
 	return err.Code == code && strings.Contains(err.Message, message)
 }
-
-func IsMlError(err *mlmodels.Error, code string, message string) bool {
-	return err.Code == code && strings.Contains(err.Message, message)
-}
diff --git a/resources/iam/test_common.go → resources/iam/test_common_utils.go b/resources/iam/test_common.go → resources/iam/test_common_utils.go
diff --git a/utils/file_reader.go b/utils/file_reader.go
diff --git a/utils/file_reader_test.go b/utils/file_reader_test.go
diff --git a/utils/string_utils.go → utils/test_string_utils.go b/utils/string_utils.go → utils/test_string_utils.go
diff --git a/utils/string_utils_test.go → utils/test_string_utils_test.go b/utils/string_utils_test.go → utils/test_string_utils_test.go