Update gfp12.go #33
Merged
Update gfp12.go #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BrandonKoerner
commented
Jun 8, 2023
BrandonKoerner
commented
- fix simple bug in gfp12.MulScalar
- used e in input values instead of a (check lines)
fix simple bug in gfp12.MulScalar
bwesterb
approved these changes
Jun 9, 2023
armfazh
approved these changes
Jun 9, 2023
|
Thanks @ReewassSquared |
fjl
pushed a commit
to ethereum/go-ethereum
that referenced
this pull request
Jan 2, 2025
The `a` parameter should be used in the `MulScalar` function. The upstream cloudflare and google repos have already merged fixes. Reference: * https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2 * cloudflare/bn256#33
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 3, 2025
The `a` parameter should be used in the `MulScalar` function. The upstream cloudflare and google repos have already merged fixes. Reference: * https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2 * cloudflare/bn256#33
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 4, 2025
The `a` parameter should be used in the `MulScalar` function. The upstream cloudflare and google repos have already merged fixes. Reference: * https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2 * cloudflare/bn256#33
sebastianst
pushed a commit
to ethereum-optimism/op-geth
that referenced
this pull request
Jan 23, 2025
The `a` parameter should be used in the `MulScalar` function. The upstream cloudflare and google repos have already merged fixes. Reference: * https://cs.opensource.google/go/x/crypto/+/8d7daa0c54b357f3071e11eaef7efc4e19a417e2 * cloudflare/bn256#33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.