Fix nested map renders #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manatarms
force-pushed
the
fix-nested-map-renders
branch
5 times, most recently
from
c93042e to
2f548eb
Compare
manatarms
force-pushed
the
fix-nested-map-renders
branch
from
2f548eb to
d87352d
Compare
|
awesome stuff! my only nitpick would be to expose the values as a flag (like the other configuration options) and allow setting the hostname and path like we do in the provider. no big deal though as we can add another PR to do that if we push forward with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unconditionally rendering interfaces, even if it was a map of interfaces. This lead to us just rendering the only first value in the map as an interface.
This fix handles the case for map of interfaces.