Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x machine #119

Closed
wants to merge 1 commit into from
Closed

Add s390x machine #119

wants to merge 1 commit into from

Conversation

claucece
Copy link
Contributor

This PR is still WP.

@armfazh , where did you get the sha for the golang image for the other machines?

@armfazh
Copy link
Contributor

armfazh commented May 27, 2020

@armfazh , where did you get the sha for the golang image for the other machines?

I used arm64v8/golang:1.14.0 however, I looked for that image today and has a different sha value.
Maybe we must move to tags rather than shasum.

- name: Testing
run: |
docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
docker run --rm -v `pwd`:`pwd` -w `pwd` s390x/golang@$SHA256 go test -v ./...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was investigating what happens with s390x, it seems fetching code causes invalid signature, hence one trick is to vendor dependencies. Include the vendor folder and the following:

Suggested change
docker run --rm -v `pwd`:`pwd` -w `pwd` s390x/golang@$SHA256 go test -v ./...
docker run --rm -v `pwd`:`pwd` -w `pwd` s390x/golang@$SHA256 go test -mod=vendor -v ./...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm.. not a big fan of vendoring. I'll investigate tomorrow if there is an alternative.. if not, let's use vendor.

@claucece
Copy link
Contributor Author

I used arm64v8/golang:1.14.0 however, I looked for that image today and has a different sha value.

Yeah, I also saw that. I'll see how it looks with tags ;)

@armfazh
Copy link
Contributor

armfazh commented May 27, 2020

@claucece please take a look on #121. I did lots of changes to make it work.
The bug was raised by s390x because it is big endian. In some parts of the code, it always assumes little endian ordering.

@claucece
Copy link
Contributor Author

claucece commented Jun 4, 2020

Closing this PR as the other was merged.

@claucece claucece closed this Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants