Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document experimental JSON configuration support for Wrangler #7166

Merged
merged 3 commits into from
Jan 26, 2023

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jan 5, 2023

No description provided.

@penalosa penalosa requested review from deadlypants1973 and a team January 5, 2023 17:15
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 84e4630
Status: ✅  Deploy successful!
Preview URL: https://4e58c47f.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://penalosa-json-config-wrangle.cloudflare-docs-7ou.pages.dev

View logs

@admah
Copy link
Contributor

admah commented Jan 5, 2023

@penalosa are you also planning to add a mention of this to the main docs site (/workers/wrangler/configuration/)?

@@ -43,6 +43,8 @@ Flags:
- Show help.
- `--version` {{<type>}}boolean{{</type>}}
- Show version number.
- `--json-config` {{<type>}}boolean{{</type>}}
- ⚠️ Experimental: Read configuration from a `wrangler.json` file, instead of `wrangler.toml`. `wrangler.json` is a [JSONC](https://code.visualstudio.com/docs/languages/json#_json-with-comments) file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is saying that the command is experimental, it would be good to add experimental in parentheses or add a period rather than a colon

@JacobMGEvans
Copy link
Contributor

I think the change in flag name is a great addition, very explicit. My approval stands. 👍

@penalosa penalosa merged commit 01a9fef into production Jan 26, 2023
@penalosa penalosa deleted the penalosa/json-config-wrangler branch January 26, 2023 16:41
deadlypants1973 pushed a commit that referenced this pull request Jan 30, 2023
* Document experimental JSON configuration support for Wrangler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants