Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify "Source of Truth" wording #7278

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Clarify "Source of Truth" wording #7278

merged 2 commits into from
Jan 20, 2023

Conversation

penalosa
Copy link
Contributor

Follow on from #6786

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 17, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 490537f
Status: ✅  Deploy successful!
Preview URL: https://aefdfad0.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://penalosa-patch-1.cloudflare-docs-7ou.pages.dev

View logs

JacobMGEvans
JacobMGEvans suggested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we start using Wrangler configuration verbiage then reference i.e. wrangler.toml due to the JSON support that will be available in the near future.

@admah
Copy link
Contributor

admah commented Jan 17, 2023

@JacobMGEvans I think we'll need to think through that verbiage more and do that work as a part of a larger docs effort for JSON support.

@lrapoport-cf lrapoport-cf mentioned this pull request Jan 17, 2023
Merged
6 tasks
JacobMGEvans
JacobMGEvans approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@JacobMGEvans JacobMGEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the conversation internally with @admah about my concerns considering a more umbrella terminology around Wrangler configuration this PR is not blocked by that.

Tentative to resolution with @rozenmd comments.

@penalosa penalosa merged commit 15a4020 into production Jan 20, 2023
@penalosa penalosa deleted the penalosa-patch-1 branch January 20, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozenmd rozenmd rozenmd left review comments

@deadlypants1973 deadlypants1973 deadlypants1973 approved these changes

@JacobMGEvans JacobMGEvans JacobMGEvans approved these changes

@londonzhang londonzhang Awaiting requested review from londonzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@penalosa @admah @rozenmd @JacobMGEvans @deadlypants1973