Make rate limiting correlate optional
#281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking into an issue in the Terraform provider, I've found that the `correlate` values for rate limiting are always being sent regardless of whether the value is set or not. This isn't really a big deal as I'm assuming the API endpoint just disregard it but for the Terraform provider, it does make the state management more difficult and messy than what it needs to be due to the nested types. Instead of always sending the value, I've updated the struct to allow `nil` and to omit when the values are empty resulting in a fix for the issues downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into an issue in the Terraform provider, I've found that
the
correlatevalues for rate limiting are always being sentregardless of whether the value is set or not. This isn't really a big
deal as I'm assuming the API endpoint just disregard it but for the
Terraform provider, it does make the state management more difficult and
messy than what it needs to be due to the nested types.
Instead of always sending the value, I've updated the struct to allow
niland to omit when the values are empty resulting in a fix for theissues downstream.