Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove phase SBFM from rulesets #3824

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

gcloudflare
Copy link
Contributor

@gcloudflare gcloudflare commented Jan 13, 2025

We now longer allow configuring SBFM phase rulesets with the rulesets API. They can only be configured with the bot management API. We have sent emails to customers about this change asking them to switch from the ruleset resource to the bot management resource in terraform.

Description

Rules are added to rulesets before they are deployed at the edge. So we want customers to only configure the rules once they have been deployed and in a way that has been tested.

Has your change been tested?

This PR only removes a phase from the rulesets resource.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

changelog detected ✅

@gcloudflare gcloudflare marked this pull request as ready for review January 13, 2025 13:58
@jacobbednarz jacobbednarz merged commit ecbef96 into cloudflare:master Jan 15, 2025
7 checks passed
@github-actions github-actions bot added this to the v0.114.0 milestone Jan 15, 2025
Copy link
Contributor

This functionality has been released in v0.114.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants