-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support workers plain and secret text bindings #465
Conversation
Text: text, | ||
} | ||
case WorkerSecretTextBindingType: | ||
bindingListItem.Binding = WorkerSecretTextBinding{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: There is no text
in the list response for secrets values (compared to plain text values).
scriptParams := WorkerScriptParams{ | ||
Script: workerScript, | ||
Bindings: map[string]WorkerBinding{ | ||
"b1": WorkerSecretTextBinding{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above you mentioned there isn't a text for WorkerSecretTextBinding
. Is this assertion still correct then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is writing the value, yes. Reading it in List
doesn't give a text value back.
Edit: Updated the other comment to clarify it's about List
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Thanks for that; it makes sense now 🙂
Thanks @blakeembrey ! |
Closes #464.
Description
Adds support for
plain_text
andsecret_text
bindings to workers.Has your change been tested?
I have included tests locally based on the documentation and results from curl commands on my local account.
Types of changes
What sort of change does your code introduce/modify?
Checklist: