Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workers): Adds support for Workers secrets #475

Merged
merged 1 commit into from
Aug 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions workers_secrets.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
package cloudflare

import (
"context"
"encoding/json"
"fmt"
"net/http"

"github.com/pkg/errors"
)

// WorkersPutSecretRequest provides parameters for creating and updating secrets
type WorkersPutSecretRequest struct {
Name string `json:"name"`
Text string `json:"text"`
Type WorkerBindingType `json:"type"`
}

// WorkersSecret contains the name and type of the secret
type WorkersSecret struct {
Name string `json:"name"`
Type string `json:"secret_text"`
}

// WorkersPutSecretResponse is the response received when creating or updating a secret
type WorkersPutSecretResponse struct {
Response
Result WorkersSecret `json:"result"`
}

// WorkersListSecretsResponse is the response received when listing secrets
type WorkersListSecretsResponse struct {
Response
Result []WorkersSecret `json:"result"`
}

// SetWorkersSecret creates or updates a secret
// API reference: https://api.cloudflare.com/
func (api *API) SetWorkersSecret(ctx context.Context, script string, req *WorkersPutSecretRequest) (WorkersPutSecretResponse, error) {
uri := fmt.Sprintf("/accounts/%s/workers/scripts/%s/secrets", api.AccountID, script)
res, err := api.makeRequestContext(ctx, http.MethodPut, uri, req)
if err != nil {
return WorkersPutSecretResponse{}, errors.Wrap(err, errMakeRequestError)
}

result := WorkersPutSecretResponse{}
if err := json.Unmarshal(res, &result); err != nil {
return result, errors.Wrap(err, errUnmarshalError)
}

return result, err
}

// DeleteWorkersSecret deletes a secret
// API reference: https://api.cloudflare.com/
func (api *API) DeleteWorkersSecret(ctx context.Context, script, secretName string) (Response, error) {
uri := fmt.Sprintf("/accounts/%s/workers/scripts/%s/secrets/%s", api.AccountID, script, secretName)
res, err := api.makeRequestContext(ctx, http.MethodDelete, uri, nil)
if err != nil {
return Response{}, errors.Wrap(err, errMakeRequestError)
}

result := Response{}
if err := json.Unmarshal(res, &result); err != nil {
return result, errors.Wrap(err, errUnmarshalError)
}

return result, err
}

// ListWorkersSecrets lists secrets for a given worker
// API reference: https://api.cloudflare.com/
func (api *API) ListWorkersSecrets(ctx context.Context, script string) (WorkersListSecretsResponse, error) {
uri := fmt.Sprintf("/accounts/%s/workers/scripts/%s/secrets", api.AccountID, script)
res, err := api.makeRequestContext(ctx, http.MethodGet, uri, nil)
if err != nil {
return WorkersListSecretsResponse{}, errors.Wrap(err, errMakeRequestError)
}

result := WorkersListSecretsResponse{}
if err := json.Unmarshal(res, &result); err != nil {
return result, errors.Wrap(err, errUnmarshalError)
}

return result, err
}
111 changes: 111 additions & 0 deletions workers_secrets_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
package cloudflare

import (
"context"
"fmt"
"net/http"
"testing"

"github.com/stretchr/testify/assert"
)

func TestWorkers_SetWorkersSecret(t *testing.T) {
setup(UsingAccount("foo"))
defer teardown()

response := `{
"result": {
"name" : "my-secret",
"type": "secret_text"
},
"success": true,
"errors": [],
"messages": []
}`

mux.HandleFunc("/accounts/foo/workers/scripts/test-script/secrets", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "PUT", r.Method, "Expected method 'PUT', got %s", r.Method)
w.Header().Set("content-type", "application/javascript")
fmt.Fprintf(w, response)
})
req := &WorkersPutSecretRequest{
Name: "my-secret",
Text: "super-secret",
}
res, err := client.SetWorkersSecret(context.Background(), "test-script", req)
want := WorkersPutSecretResponse{
successResponse,
WorkersSecret{
Name: "test",
Type: "secret_text",
},
}

if assert.NoError(t, err) {
assert.Equal(t, want.Response, res.Response)
}
}

func TestWorkers_DeleteWorkersSecret(t *testing.T) {
setup(UsingAccount("foo"))
defer teardown()

response := `{
"result": {
"name" : "test",
"type": "secret_text"
},
"success": true,
"errors": [],
"messages": []
}`

mux.HandleFunc("/accounts/foo/workers/scripts/test-script/secrets/my-secret", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "DELETE", r.Method, "Expected method 'DELETE', got %s", r.Method)
w.Header().Set("content-type", "application/javascript")
fmt.Fprintf(w, response)
})

res, err := client.DeleteWorkersSecret(context.Background(), "test-script", "my-secret")
want := successResponse

if assert.NoError(t, err) {
assert.Equal(t, want, res)
}
}

func TestWorkers_ListWorkersSecret(t *testing.T) {
setup(UsingAccount("foo"))
defer teardown()

response := `{
"result": [{
"name" : "my-secret",
"type": "secret_text"
}],
"success": true,
"errors": [],
"messages": []
}`

mux.HandleFunc("/accounts/foo/workers/scripts/test-script/secrets", func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, "GET", r.Method, "Expected method 'GET', got %s", r.Method)
w.Header().Set("content-type", "application/javascript")
fmt.Fprintf(w, response)
})

res, err := client.ListWorkersSecrets(context.Background(), "test-script")
want := WorkersListSecretsResponse{
successResponse,
[]WorkersSecret{
{
Name: "my-secret",
Type: "secret_text",
},
},
}

if assert.NoError(t, err) {
assert.Equal(t, want.Response, res.Response)
}
}