add support for Custom Hostnames without SSL #666
Merged
+81
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the client to match the fact that the
ssl
is an optional (yet almost always used) attribute on the custom hostnames API. Breaking change since an existing struct field was modified.One caveat/part I haven't implemented here is that to turn off SSL for a hostname, you have to PATCH with a payload of
{"hostname: "x", "ssl":"null"}
, quotes important, simply relying onomitempty
({"hostname: "x"}
) is not enough.Types of changes
What sort of change does your code introduce/modify?
Checklist: