add ability to convert between types consistenly #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
force-pushed
the
add-convert-types
branch
from
60809da to
f267a32
Compare
In our downstream systems and tools (terraform-provider-cloudflare,
cf-terraforming) we often have to swap between Golang types and pseudo
types. One example is with Terraform schemas and our struct types. There
isn't a consistent way which means they are all implemented slightly
different and there isn't a great convention. This commit aims to solve
that by introducing a standard to adhear to by introducing a number of
helper methods.
- <type>Ptr: Accepts a value and returns a pointer.
- <type>Value: Accepts a pointer and returns a value.
- <type>PtrSlice: Accepts a slice of values and returns a slice of pointers.
- <type>ValueSlice: Accepts a slice of pointers and returns a slice of values.
- <type>Map: Accepts a string map of values into a string map of pointers.
- <type>ValueMap: Accepts a string map of pointers into a string map of values.
Example in Terraform where the schema is a string but we want a pointer.
```go
examplePtr := cloudflare.StringPtr(d.Get("example").(string))
```
jacobbednarz
force-pushed
the
add-convert-types
branch
from
f267a32 to
277b4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our downstream systems and tools (terraform-provider-cloudflare,
cf-terraforming) we often have to swap between Golang types and pseudo
types. One example is with Terraform schemas and our struct types. There
isn't a consistent way which means they are all implemented slightly
different and there isn't a great convention. This commit aims to solve
that by introducing a standard to adhear to by introducing a number of
helper methods.
<type>Ptr: Accepts a value and returns a pointer.<type>Value: Accepts a pointer and returns a value.<type>PtrSlice: Accepts a slice of values and returns a slice of pointers.<type>ValueSlice: Accepts a slice of pointers and returns a slice of values.<type>Map: Accepts a string map of values into a string map of pointers.<type>ValueMap: Accepts a string map of pointers into a string map of values.Example in Terraform where the schema is a string but we want a pointer.