Skip to content
This repository has been archived by the owner on Sep 6, 2023. It is now read-only.

can't set 'none' to samesite #31

Closed
tyiss opened this issue Nov 27, 2019 · 2 comments
Closed

can't set 'none' to samesite #31

tyiss opened this issue Nov 27, 2019 · 2 comments

Comments

@tyiss
Copy link

tyiss commented Nov 27, 2019

The code is limiting the possible values of samesite attribute to either 'Strict' or 'Lax'.
however there is another possible value: none.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies#SameSite_cookies

@eberbis
Copy link
Contributor

eberbis commented Jan 14, 2020

Following up @tyiss comment, I came across the same issue.
Anything different than Strict or Lax is currently considered as invalid. I have implemented a change to allow for None.

@p0pr0ck5, would you or any contributor have some time to review it? #32

Thanks in advance

@jdesgats
Copy link
Contributor

jdesgats commented Feb 4, 2020

I just merged the PR #32 mentioned by @eberbisl. This issue should be fixed now.

@jdesgats jdesgats closed this as completed Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants